Bump binrw to clear future-incompatibilities warning #310

New issue

Closed

opened 2026-07-31 22:37:37 +02:00 by jqueuniet · 0 comments

jqueuniet commented

2026-07-31 22:37:37 +02:00

Owner

Summary

binrw 0.15.1 emits a future-incompatibilities warning on every build (host and
wasm32-unknown-unknown alike): "the following packages contain code that will be
rejected by a future version of Rust: binrw v0.15.1". It affects all parser crates,
since they all depend on binrw through dm2-binrw.

Motivation

The warning covers a soundness/behaviour change the compiler will eventually turn into a
hard error, so today's warning becomes tomorrow's broken build on a routine toolchain
bump. Clearing it now keeps builds quiet and de-risks future rustc upgrades.

Scope / acceptance

Check for a fixed upstream binrw release and bump the workspace dependency, or
(if none exists yet) file/track the upstream report and pin via [patch] as a stopgap.
cargo report future-incompatibilities is clean for the workspace.
Full test suite still passes after the bump.

Notes

Surfaced while verifying the WASM cross-compile for #301 — not WASM-specific, reproduces
on the host build. Run cargo report future-incompatibilities --package binrw@0.15.1
for the detailed lint.

Labels

type/chore, area/tooling, priority/low.

## Summary `binrw 0.15.1` emits a `future-incompatibilities` warning on every build (host and `wasm32-unknown-unknown` alike): *"the following packages contain code that will be rejected by a future version of Rust: binrw v0.15.1"*. It affects all parser crates, since they all depend on `binrw` through `dm2-binrw`. ## Motivation The warning covers a soundness/behaviour change the compiler will eventually turn into a hard error, so today's warning becomes tomorrow's broken build on a routine toolchain bump. Clearing it now keeps builds quiet and de-risks future `rustc` upgrades. ## Scope / acceptance - Check for a fixed upstream `binrw` release and bump the workspace dependency, or (if none exists yet) file/track the upstream report and pin via `[patch]` as a stopgap. - `cargo report future-incompatibilities` is clean for the workspace. - Full test suite still passes after the bump. ## Notes Surfaced while verifying the WASM cross-compile for #301 — not WASM-specific, reproduces on the host build. Run `cargo report future-incompatibilities --package binrw@0.15.1` for the detailed lint. ## Labels `type/chore`, `area/tooling`, `priority/low`.

jqueuniet added the

type/chore

priority/low

area/tooling

labels

2026-07-31 22:37:37 +02:00

jqueuniet added this to the dm2-tools project

2026-09-03 13:46:53 +02:00

jqueuniet referenced this issue from a commit

2026-09-03 14:28:41 +02:00

chore: update dependencies

jqueuniet referenced this issue from a pull request that will close it,