bindings: SaveGame keeps its graphics.dat #451
Labels
No labels
area/ci-release
area/cli
area/docs
area/dungeon
area/ftl
area/graphics
area/gui
area/music
area/saves
area/tooling
port/amiga
port/dos
port/fm-towns
port/mac
port/pc98
port/sega-cd
priority/high
priority/low
priority/medium
type/bug
type/chore
type/docs
type/feature
type/research
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jqueuniet/dm2-tools#451
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
SaveGame's constructor takes aGraphicsArchiveonly to check the byte-exact rebuild, then drops it. Soinventory,container,createItem,previewItem,putInContainer,takeFromContainerandtoBytestake it again, andfromJsontakes the dungeon alone.Nothing checks the archive passed later: a DOS EN save takes the Mac US
graphics.datininventoryandtoByteswithout error. Output is identical for that pair, but not guaranteed for a beta or another language build.Proposal
SaveGamekeeps theDungeonFileandGraphicsArchiveit was built with (shared handles); the methods drop theirgraphicsparameter;fromJson(json, dungeon, graphics)takes both.Acceptance
SaveGamemethod takes aGraphicsArchiveafter construction.Breaking: before the next release.
Deviation in #457:
SaveGamekeeps theGraphicsArchive(shared), but not theDungeonFile. Only the dungeon's map info is used after construction, so that is all it keeps.https://claude.ai/code/session_01SnENBXnZbhNNrojZT5jbJ7