feat(magicmap): render ports whose map chips use a master palette #414

Merged
jqueuniet merged 1 commit from feat/410-master-palette-ports into main 2026-10-29 22:34:38 +01:00
Owner

First part of #410.

The magic-map guard tested is_pc_family(), which is really the 8-bit image dialect: only DOS and Mac US passed. IBM PS/V, Mac JP, PC-9801 and PC-9821 use the same palette model as DOS for map chips: 4-bit images whose 16-entry palettes index a 256-entry master. So they resolve through the same engine-verified path.

  • New guard: the trailing_palette16 flag plus a master palette, instead of the image dialect.
  • Still refused: Amiga, FM-Towns and Sega CD, which carry sub-palettes only. MagicMapError::ConsoleFamily becomes NoMasterPalette (unreleased API).
  • Test: map 0 of each of the four ports renders, and Sega CD is refused.
  • Docs: CLI help, READMEs, format doc and CHANGELOG name the supported ports.

Group B (Amiga, FM-Towns, Sega CD) stays open on #410: their map-chip colours need research before they can be enabled.

Refs #410

https://claude.ai/code/session_01WCNjYNkYSAapvFewz9wfkw

First part of #410. The magic-map guard tested `is_pc_family()`, which is really the 8-bit image dialect: only DOS and Mac US passed. IBM PS/V, Mac JP, PC-9801 and PC-9821 use the same palette model as DOS for map chips: 4-bit images whose 16-entry palettes index a 256-entry master. So they resolve through the same engine-verified path. - **New guard:** the `trailing_palette16` flag plus a master palette, instead of the image dialect. - **Still refused:** Amiga, FM-Towns and Sega CD, which carry sub-palettes only. `MagicMapError::ConsoleFamily` becomes `NoMasterPalette` (unreleased API). - **Test:** map 0 of each of the four ports renders, and Sega CD is refused. - **Docs:** CLI help, READMEs, format doc and CHANGELOG name the supported ports. Group B (Amiga, FM-Towns, Sega CD) stays open on #410: their map-chip colours need research before they can be enabled. Refs #410 https://claude.ai/code/session_01WCNjYNkYSAapvFewz9wfkw
feat(magicmap): render ports whose map chips use a master palette
All checks were successful
CI / msrv (1.90) (pull_request) Successful in 34s
CI / stable (pull_request) Successful in 1m0s
CI / audit (pull_request) Successful in 13s
CI / python bindings (3.11) (pull_request) Successful in 25s
99091c51dd
IBM PS/V, Mac JP, PC-9801 and PC-9821 resolve map-chip colours through a
256-entry master, as DOS and Mac US do; the guard now checks that
palette model instead of the 8-bit image dialect. Amiga, FM-Towns and
Sega CD, with sub-palettes only, are still refused (`NoMasterPalette`,
formerly `ConsoleFamily`).

Refs #410

Claude-Session: https://claude.ai/code/session_01WCNjYNkYSAapvFewz9wfkw
jqueuniet deleted branch feat/410-master-palette-ports 2026-10-29 22:34:38 +01:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
jqueuniet/dm2-tools!414
No description provided.