refactor(bindings)!: graphics.dat only through GraphicsArchive #442
No reviewers
Labels
No labels
area/ci-release
area/cli
area/docs
area/dungeon
area/ftl
area/graphics
area/gui
area/music
area/saves
area/tooling
port/amiga
port/dos
port/fm-towns
port/mac
port/pc98
port/sega-cd
priority/high
priority/low
priority/medium
type/bug
type/chore
type/docs
type/feature
type/research
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jqueuniet/dm2-tools!442
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "feat/440-drop-free-graphics"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes #440 (2/2). Stacked on the previous PR; retarget to
mainonce it merges.graphics*functions and the tuple-addressedGraphicsArchivemethods from dm2-convert, wasm, FFI and Python (+303 −1,803).graphics_header_json,graphics_decode_png,graphics_decode_png_transparent,graphics_decode_icon_png): CHANGELOGRemoved. The others never shipped; their Unreleased entries fold into oneGraphicsArchiveentry.--weak-refs, so a forgotten handle is freed by aFinalizationRegistry.reads.rskeeps its assertions through local tuple-addressed helpers over the handle; the two tests comparing the handle against the removed functions are gone (equivalence checked in the previous PR).Web editor migration:
graphicsHeaderJson→g.header()graphicsDecodePngTransparent(b, c1, c2, c4)→g.image(g.find(c1, c2, 1, c4), {transparent: true})graphicsDecodeIconPng(b, frames, ms, t)→g.icon(frames, {frame_ms: ms, transparent: t})https://claude.ai/code/session_01SnENBXnZbhNNrojZT5jbJ7