refactor(bindings)!: save editing only through SaveGame #450
No reviewers
Labels
No labels
area/ci-release
area/cli
area/docs
area/dungeon
area/ftl
area/graphics
area/gui
area/music
area/saves
area/tooling
port/amiga
port/dos
port/fm-towns
port/mac
port/pc98
port/sega-cd
priority/high
priority/low
priority/medium
type/bug
type/chore
type/docs
type/feature
type/research
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jqueuniet/dm2-tools!450
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "refactor/446-save-game-only"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes #446 (PR 3 of 3).
Removes the dump-in, dump-out save editor functions from convert, wasm, FFI and Python (breaking):
save_to_json_full,save_from_json_full;save_inventory_json,save_inventory_move/swap/copy/clear;save_container_json,save_container_put,save_container_take;save_item_create,save_item_preview;item_catalog_json,skill_title_json(nowGraphicsArchive.item_catalog/skill_title).Stay free:
save_to_json,save_from_json,save_info_json,skill_level,skill_experience_for_level, andsave_field_limits_json.Deviation from #446:
save_field_limits_jsonis kept. It needs only a variant string, and its test covers every committed save fixture in CI, where nodungeon.datorgraphics.datexists to open aSaveGame.Tests:
full_roundtrip.rskeeps its checks through local dump-in, dump-out helpers overSaveGame. JSON-only edits load the dump variant's fixture dungeon, used only for the map info.https://claude.ai/code/session_01SnENBXnZbhNNrojZT5jbJ7