feat(graphics): header() reports the archive family #464

Merged
jqueuniet merged 1 commit from feat/graphics-family into main 2026-10-31 19:12:32 +01:00
Owner

GraphicsArchive::header adds family: console (Amiga, Sega CD, FM-Towns) honours image's style and light, pc (DOS, Mac, PC-98, IBM PS/V) ignores them.

Decided by the new Archive::lights_images, which find_image_palette_ctx now uses too: images render through the master palette when 4-bit images carry a trailing Palette16 and a master exists. is_pc_family (8-bit dialect bit) is not the right test: Mac JP, PC-98 and PS/V fail it, yet lighting changes none of their images (checked over every image: 0 differ between style/light 0 and 5; Amiga 4364/4758 differ).

Test over the DOS, Mac US/JP, PC-98, PS/V, Amiga, Sega CD and FM-Towns fixtures. wasm README header() and image() rows updated; FFI, wasm and Python doc strings too.

Closes #461

https://claude.ai/code/session_01SnENBXnZbhNNrojZT5jbJ7

`GraphicsArchive::header` adds `family`: `console` (Amiga, Sega CD, FM-Towns) honours `image`'s `style` and `light`, `pc` (DOS, Mac, PC-98, IBM PS/V) ignores them. Decided by the new `Archive::lights_images`, which `find_image_palette_ctx` now uses too: images render through the master palette when 4-bit images carry a trailing Palette16 and a master exists. `is_pc_family` (8-bit dialect bit) is not the right test: Mac JP, PC-98 and PS/V fail it, yet lighting changes none of their images (checked over every image: 0 differ between style/light 0 and 5; Amiga 4364/4758 differ). Test over the DOS, Mac US/JP, PC-98, PS/V, Amiga, Sega CD and FM-Towns fixtures. wasm README `header()` and `image()` rows updated; FFI, wasm and Python doc strings too. Closes #461 https://claude.ai/code/session_01SnENBXnZbhNNrojZT5jbJ7
feat(graphics): header() reports the archive family
All checks were successful
CI / msrv (1.90) (pull_request) Successful in 28s
CI / audit (pull_request) Successful in 20s
CI / stable (pull_request) Successful in 57s
CI / python bindings (3.11) (pull_request) Successful in 27s
CI / msrv (1.90) (push) Successful in 28s
CI / audit (push) Successful in 20s
CI / stable (push) Successful in 57s
CI / python bindings (3.11) (push) Successful in 26s
50cf58370b
console archives (Amiga, Sega CD, FM-Towns) honour image()'s style and
light; pc ones (DOS, Mac, PC-98, IBM PS/V) render through the master
palette and ignore them. Archive::lights_images decides, as image
palette resolution does: is_pc_family would put the Japanese 4-bit
ports on the console side.

Closes #461

Claude-Session: https://claude.ai/code/session_01SnENBXnZbhNNrojZT5jbJ7
jqueuniet deleted branch feat/graphics-family 2026-10-31 19:12:32 +01:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
jqueuniet/dm2-tools!464
No description provided.